RFR 8164800: Cross targeting Windows

[Sundararajan Athijegannathan]

Fixing along with another fix ->
http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-August/009210.html

Thanks

-Sundar


On 8/26/2016 9:56 PM, Remi Forax wrote:
> Hi Sundararajan,
> Also, in createArgs(), instead Collections.unmodifiableList(), you can use List.of().
>
> regards,
> Rémi
>
> ----- Mail original -----
>> De: "Sundararajan Athijegannathan" <sundararajan.athijegannathan at oracle.com>
>> À: "Alan Bateman" <Alan.Bateman at oracle.com>, "jigsaw-dev" <jigsaw-dev at openjdk.java.net>
>> Envoyé: Vendredi 26 Août 2016 18:08:12
>> Objet: Re: RFR 8164800: Cross targeting Windows
>> Hmm.. I saw another RuntimeException in the same file for another issue..
>>
>> I guess I'll have to deal with this change when doing another fix in
>> that file - I do have one for reading java.version from java.base
>> descriptor. I'll clean it up when doing that fix.
>>
>> -Sundar
>>
>>
>> On 8/26/2016 9:37 PM, Alan Bateman wrote:
>>>
>>> On 26/08/2016 15:54, Sundararajan Athijegannathan wrote:
>>>> Hi,
>>>>
>>>> Fixed as suggested:
>>>> http://cr.openjdk.java.net/~sundar/8164800/webrev.02/
>>>>
>>>> * Field name changed to targetOsName
>>>>
>>>> * Throwing RuntimeException if os name can't be determined from
>>>> java.base
>>>>
>>>>
>>> This looks okay except for RuntimeException, should this be
>>> PlugException with an appropriate cause? Also for the message then it
>>> would be better to say that the TargetPlatform attribute is missing
>>> from the java.base module.
>>>
>>> -Alan