RFR [9] 8170859 : Run time and tool support for ModuleResolution

Chris Hegarty chris.hegarty at oracle.com
Fri Dec 9 14:14:45 UTC 2016


I'll work with Alan to get these changes re-based on top of
the refactoring in jake. Consider this review request withdrawn.

-Chris.

On 09/12/16 14:09, Remi Forax wrote:
> Thanks Alan,
> so I withdraw my snarky comment.
>
> Rémi
>
>
> On December 9, 2016 12:25:19 PM GMT+01:00, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>> On 08/12/2016 14:41, Remi Forax wrote:
>>
>>> Chris,
>>> this patch is rather ugly.
>>> Patching the ModuleDescriptor is not a good idea, maybe it's means
>> that we need a system of metadata associated with a ModuleDescriptor,
>>> the hash of a module (which is not part of the module spec but the
>> OpenJDK implementation) can be also considered as metadata.
>>>
>> There is refactoring in flight that drops the JDK-specific meta data
>>from ModuleDescriptor. Once all the pieces are merged together then it
>> should look a lot better.
>>
>> -Alan.
>


More information about the jigsaw-dev mailing list