Review Request: JDK-8171201 & JDK-8171202: Drop java.compact$N aggregator modules

Alan Bateman Alan.Bateman at oracle.com
Wed Dec 14 08:03:41 UTC 2016


On 14/12/2016 06:49, Mandy Chung wrote:

> JDK-8171201: Drop java.compact$N aggregator modules
> JDK-8171202: Rename jdk.crypto.pkcs11 and jdk.pack200 to end with Java letters
>
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8171201%2b8171202/webrev.00/
>
>
The hg moves are showing up as new files in the webrev - is that because 
the webrev is on several repos?

In the LimitModsTest test then it might be simpler to leave 
java.scripting out of the test. Also in the java.se aggregator then it 
looks like the module comment has a line break after "The module 
defining" and can probably be fixed as part of this edit.

Otherwise looks good to me.

-Alan


More information about the jigsaw-dev mailing list