RFR 8171138: Remove FileCopierPlugin
Mandy Chung
mandy.chung at oracle.com
Thu Dec 15 04:36:19 UTC 2016
> On Dec 14, 2016, at 8:35 PM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>
> Hi Mandy,
>
> Thanks for your review. I updated to handle TOP entries in accept callback uniformly: http://cr.openjdk.java.net/~sundar/8171138/webrev.01/index.html
395 // Copy TOP files of the "java.base" module (only)
396 if ("java.base".equals(file.moduleName())) {
It may be better to throw an InternalError for any entry other than
“java.base”.
Otherwise looks good. You can fix this before you push. No need for a new webrev.
Mandy
More information about the jigsaw-dev
mailing list