RFR: 8171400: Move checking of duplicate packages in the boot layer to link time

Claes Redestad claes.redestad at oracle.com
Mon Dec 19 18:14:23 UTC 2016



On 2016-12-19 17:35, Alan Bateman wrote:
>
>
> On 19/12/2016 13:12, Claes Redestad wrote:
>>
>> I think that'd break things, since we need a logical || here (what you
>> suggest is an &&):
>>
>> If we need to do post resolution checks (due to patching the boot
>> layer or such) we must
>> check (asthe information in SystemModules is now stale), but if we
>> don't need to do post
>> resolution check and there's a possibility for split packages in the
>> image we still need
>> to check.
> Sorry, you're right. If someone creates a run-time image contains
> overlapping packages this check is required even and irrespective of the
> other conditions. So yes, it is "||".

Good, thanks.

I polished the comment you took issue with further, updated in place:

http://cr.openjdk.java.net/~redestad/8171400/webrev.01/

Good to go?

/Claes


More information about the jigsaw-dev mailing list