Review Request: JDK-8168836 Minor clean up on warning/error messages on --add-exports and --add-reads

Mandy Chung mandy.chung at oracle.com
Mon Dec 19 21:02:14 UTC 2016


> On Dec 19, 2016, at 11:39 AM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
>> On Dec 19, 2016, at 9:45 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>> 
>> 
>> 
>> On 19/12/2016 01:44, Mandy Chung wrote:
>>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8168836/webrev.00/
>>> 
>>> This patch improves the warning/error message to include the option name, emit a warning if unknown module is specified with —-patch-module be consistent with the options.
>>> 
>> The implementation update looks good.  As --patch-modules is a slow path then you could use cf.findModule(mn).ifPresent(…)
> 
> Fixed.

Having a second thought, I prefer to keep the if statement testing isPresent().  Or I could do something like  cf.findModule(mn).orElse(warnUnknownModule(PATCH_MODULE, mn)) but warnUnknownModule method would need to return ResolvedModule.

Mandy



More information about the jigsaw-dev mailing list