RFR 8149391: Fix module dependencies in java/util

Mandy Chung mandy.chung at oracle.com
Mon Feb 8 23:58:45 UTC 2016


> On Feb 8, 2016, at 3:36 PM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
> 
>> 
>> On Feb 8, 2016, at 1:23 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>> 
>> 
>>> On Feb 8, 2016, at 11:43 AM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
>>> 
>>> Hi.
>>> 
>>> Could you please take a look on additional module dependencies to be added for tests in java/util. There is more work to do for :jdk_core test group, which is to come separately.
>>> 
>>> JDK9 changes: http://cr.openjdk.java.net/~shurailine/8149391/webrev.jdk9.00/
>>> Jake changes: http://cr.openjdk.java.net/~shurailine/8149391/webrev.jake.00/
>> 
>> Looks okay.  I can sponsor and push the patches for you.
>> 
>> One question:  test/java/util/logging/modules/GetResourceBundleTest.java - what uses jdk.zipfs?
> 
> This dependency is required by this line:
>        assertTrue(CompilerUtils.compile(PKG_SRC_DIR, PKG_DEST_DIR,
>                "-modulepath", MOD_DEST_DIR.toString()));
> 
> It is currently believed to be a bug in javac. A separate bug will be created on that.

Ah that’s right.  Thanks.

I’ll push your changesets.

Mandy



More information about the jigsaw-dev mailing list