Round #4: RFR: 8049365 - Update JDI and JDWP for modules

Lois Foltan lois.foltan at oracle.com
Tue Jan 26 12:47:25 UTC 2016


On 1/26/2016 6:48 AM, serguei.spitsyn at oracle.com wrote:
> Please, review this initial fix for the M4 Jigsaw task:
> https://bugs.openjdk.java.net/browse/JDK-8049365
>
>
> Jdk webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.4/
>
> Hotspot webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8049365-Jigsaw-hs.4/

Hotspot changes look good.  Thank you Serguei for incorporating my feedback.
Lois

>
>
> Summary:
>   This round resolves most of the Alan's comments from previous review 
> rounds.
>   It also resolves last review comments from Lois.
>
>   Two follow-up tasks were filed:
> https://bugs.openjdk.java.net/browse/JDK-8148106
> https://bugs.openjdk.java.net/browse/JDK-8148103
>
>
> Testing:
>    The co-located nsk.jvmti and nsk.jdi tests are all passed.
>    The jdk_jdi tests are passed as well.
>
>
> Also, please, refer to a related M4 Jigsaw task:
> https://bugs.openjdk.java.net/browse/JDK-8049364
> Update JVM TI for modules
>
>
> Thanks,
> Serguei



More information about the jigsaw-dev mailing list