Review Request: JDK-8155955: packager needs to determine the root modules to create JRE image
Alan Bateman
Alan.Bateman at oracle.com
Sat Jun 4 07:01:06 UTC 2016
On 04/06/2016 01:26, Mandy Chung wrote:
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8155955/webrev.00/
>
> This provides some utility methods for packager to determine the platform modules to help packager independent of any API change. This helper class will ultimately move to the packager implementation when FX upgrades its boot JDK later in JDK 9 release.
>
I think more context is needed here. I'm generally concerned that this
is duplicating code and creating a maintenance issue. Also it just
doesn't seem right for the FX packager to be concerned with the subset
of the modules that are defined to the boot and platform class loaders.
If it needs the names of the modules in the JRE build then this is
something that we can only compute in the build.
-Alan
More information about the jigsaw-dev
mailing list