RFR of JDK-8159879: Some typo and minor test bugs in ava/lang/module/ModuleReferenceTest.java and ConfigurationTest.java

Hamlin Li huaming.li at oracle.com
Tue Jun 21 01:41:36 UTC 2016


On 2016/6/20 19:40, Alan Bateman wrote:
>
>
> On 20/06/2016 10:32, Hamlin Li wrote:
>>
>> Would you please review the patch for following bug?
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8159879
>> webrev: http://cr.openjdk.java.net/~mli/8159879/
> This looks okay except testServiceBindingWithConfigurations3 where the 
> original comment is correct and just need to be re-ordered to:
>
> Configuration cf1: p at 1.0 provides p.S
> Test configuration:cf2: m1 uses p.S, p at 2.0 provides p.S
> Test configuration:cf2: m1 uses p.S
Thank you for reviewing Alan.
Just pushed after modify as you suggested.

Thank you
-Hamlin
>
> -Alan
>



More information about the jigsaw-dev mailing list