RFR 8159593: Plugin Set<Category> getType() should return a Category

Jim Laskey (Oracle) james.laskey at oracle.com
Tue Jun 21 13:32:35 UTC 2016


+1 Thanks

> On Jun 21, 2016, at 10:30 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> Thanks for the review.
> 
> Please review the updated webrev :
> http://cr.openjdk.java.net/~sundar/8159593/webrev.01/
> 
> Thanks
> 
> -Sundar
> 
> On 6/21/2016 5:33 PM, Jim Laskey (Oracle) wrote:
>> 59     public static boolean isPostProcessor(Category category) {
>>  60         return category.equals(Category.VERIFIER)
>>  61                 || category.equals(Category.PROCESSOR)
>>  62                 || category.equals(Category.PACKAGER);
>>  63     }
>>  64 
>>  65     public static boolean isPreProcessor(Category category) {
>>  66         return category.equals(Category.COMPRESSOR)
>>  67                 || category.equals(Category.FILTER)
>>  68                 || category.equals(Category.MODULEINFO_TRANSFORMER)
>>  69                 || category.equals(Category.SORTER)
>>  70                 || category.equals(Category.TRANSFORMER)
>>  71                 || category.equals(Category.METAINFO_ADDER);
>>  72     }
>> 
>> Wondering if we can handle this with a field in the enum.
>> 
>> +1 otherwise.
>> 
>> 
>>> On Jun 21, 2016, at 7:25 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>>> 
>>> Please review http://cr.openjdk.java.net/~sundar/8159593/webrev.00/ for
>>> https://bugs.openjdk.java.net/browse/JDK-8159593
>>> 
>>> Thanks,
>>> -Sundar
> 



More information about the jigsaw-dev mailing list