RFR 8157936: Files.size(Path p) returns 0 if path is from JrtFileSystem with exploded build

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Mon Jun 27 08:16:48 UTC 2016


Thanks for the review. I'll include a space in test and push.

-Sundar


On 6/27/2016 1:42 PM, Paul Sandoz wrote:
>> On 27 Jun 2016, at 09:03, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>>
>> Please review http://cr.openjdk.java.net/~sundar/8157936/webrev.00/ for
>> https://bugs.openjdk.java.net/browse/JDK-8157936
>>
>> Note: no regrestion test added as jrt-fs automated testing is not done
>> in exploded mode JDK. But, I'm adding a simple class file size test to
>> Basic.java so that a manual run of jrt-fs tests on exploded image can
>> verify the fix.
>>
> Look good.
>  146                 return isDirectory()? 0 : Files.size(path);
> Trivially a missing space between ‘)’ and ‘?’.
>
> Paul.
>



More information about the jigsaw-dev mailing list