RFR: JDK-8150998: Fix module dependences in java/lang tests
Alexandre (Shura) Iline
alexandre.iline at oracle.com
Wed Mar 2 22:13:53 UTC 2016
> On Mar 2, 2016, at 2:03 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>
>
>> On Mar 2, 2016, at 12:38 PM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
>>
>> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.02/
>
>
> test/java/lang/instrument/MakeJAR2.sh
> -XaddExports should not be brought to jdk9.
>
> test/java/lang/management/ManagementFactory/TEST.properties
> Should it be moved to test/java/lang/management since all tests under it are testing java/lang/management?
>
> should this require java.management instead? I expect most tests only need java.management.
10 of 11 tests in java/lang/management/ManagementFactory throw
java.lang.NoClassDefFoundError: com/sun/management/internal/GarbageCollectorExtImpl
when jdk.management is not available.
java/lang/management/ManagementFactory/GetObjectName.java indeed works with java.management. Are you suggesting to get back to declaring dependencies in every test? That would include java/lang/management/ManagementFactory/GetObjectName.java into a run when java.management is present but not jdk.management.
Shura
>
> What about test/javax/management and other tests for java.management module? Are you planning to migrate to use Test.properties gradually? Maybe good to it for the entire module at a time.
>
> Mandy
More information about the jigsaw-dev
mailing list