RFR: JDK-8150998: Fix module dependences in java/lang tests

[Alexandre (Shura) Iline]

> On Mar 2, 2016, at 2:56 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
>> On Mar 2, 2016, at 2:13 PM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
>> 
>> 
>>> On Mar 2, 2016, at 2:03 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>> 
>>> 
>>>> On Mar 2, 2016, at 12:38 PM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
>>>> 
>>>> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.02/
>>> 
>>> 
>>> test/java/lang/instrument/MakeJAR2.sh
>>> -XaddExports should not be brought to jdk9.
>>> 
>>> test/java/lang/management/ManagementFactory/TEST.properties
>>> Should it be moved to test/java/lang/management since all tests under it are testing java/lang/management?
>>> 
>>> should this require java.management instead?  I expect most tests only need java.management.
>> 
>> 10 of 11 tests in java/lang/management/ManagementFactory throw 
>> java.lang.NoClassDefFoundError: com/sun/management/internal/GarbageCollectorExtImpl 
>> when jdk.management is not available.
>> 
> 
> Thanks for the stack trace you sent offline.
> 
> I think it’s a bug.  java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.  Can you help file an issue?
> 
>> java/lang/management/ManagementFactory/GetObjectName.java indeed works with java.management. Are you suggesting to get back to declaring dependencies in every test?
> 
> I agree with Jon that declaring the module dependences in each test makes it explicitly but either way is fine with me.
> 
>> That would include java/lang/management/ManagementFactory/GetObjectName.java into a run when java.management is present but not jdk.management. 
> 
> This reveals a bug.

I will redo the fix with this new info.

Shura

> 
> Mandy