RFR: JDK-8150998: Fix module dependences in java/lang tests

Mandy Chung mandy.chung at oracle.com
Fri Mar 4 00:13:48 UTC 2016


Shura,

> On Mar 3, 2016, at 12:11 PM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
> 
> Hi.
> 
> Could you please have another look on the webrev.
> 
> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jake.03/
> http://cr.openjdk.java.net/~shurailine/8150998/webrev.jdk9.03/


I have pushed the patch in webrev.jdk9.03.


> I have addressed all the comments except moving the fix of test/java/lang/management/MemoryMXBean/PendingAllGC.sh to JDK9, as this test is already different in JDK9 and Jake, so a fix in JDK9 will be overridden.

  30 # @modules java.base/jdk.internal.misc 

This change should also be in JDK 9 as well. Anyway, I pushed the patch from webrev.jake.03 to jake except FieldSetAccessibleTest.java.

Another alternative is to get the modules in the boot layer
   Layer.boot().stream().map(Module::getName)

Mandy


More information about the jigsaw-dev mailing list