[9-jake] Review request: 8151320: Remove unnecessary addReads from JavaFX
Kevin Rushforth
kevin.rushforth at oracle.com
Tue Mar 8 00:10:48 UTC 2016
Yes, I'll deal with all of the "FIXME" comments (and not just the ones
you see in the webrev) separately.
Thanks.
-- Kevin
Mandy Chung wrote:
>> On Mar 5, 2016, at 3:31 PM, Kevin Rushforth <Kevin.Rushforth at oracle.COM> wrote:
>>
>> Please review the following:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8151320
>> http://cr.openjdk.java.net/~kcr/8151320/webrev.00/
>>
>> Now that addReads are no longer necessary in cases where we use core reflection [1] we will eliminate these unneeded calls in the FX jake repo.
>>
>>
>
> The patch looks fine to me. There are some FIXME comments that I assume you will clean up separately.
>
> Mandy
>
>
>> -- Kevin
>>
>> [1] http://mail.openjdk.java.net/pipermail/jpms-spec-experts/2016-March/000231.html
>>
>>
>
>
More information about the jigsaw-dev
mailing list