Initial webrev with changes for JDK 9

Naoto Sato naoto.sato at oracle.com
Tue Mar 8 21:37:15 UTC 2016


Hello,

I reviewed ResourceBundle code and related locale data changes. Overall 
it looks good to me. Here are some minor comments:

java.util.ResourceBundle.java

- In the class description, there are two occurrences of example 
explaing service provider type (i.e., basename+"Provider"). It seems a 
bit redundant. If they should be there in both locations, then I'd use 
the same example. Currently, one base name is "p.MyResources", and the 
other is "com.example.app.MyResources".

- This is sort of a hypothetical situation but what if a named module 
provides both local ResourceBundle, and a ResourceBundleProvider that 
"happens" to have that base name but returns a different bundle 
implementation? I guess ResourceBundleProvider wins, and I would expect 
that precedence described somewhere.

- Line 626-630: This comment of CacheKey class should include some 
description for the newly added "module" key. Same is true for line 
1620-1623.

sun.util.resources.LocaleData.java

- line 233: Can be removed, as it is redundant.

Naoto

On 3/8/16 7:48 AM, Alan Bateman wrote:
>
> I've refreshed the webrevs here:
>    http://cr.openjdk.java.net/~alanb/8142968/1
>
> so that we have a snapshot of what is currently in the jigsaw/jake
> forest. The webrves are against jdk-9+108.
>
> I plan to send mail to jdk9-dev soon proposing that we integrate a
> snapshot into JDK 9 before the end of March.
>
> -Alan.


More information about the jigsaw-dev mailing list