Initial webrev with changes for JDK 9 - jimage
Alan Bateman
Alan.Bateman at oracle.com
Wed Mar 9 09:02:16 UTC 2016
On 08/03/2016 18:07, Roger Riggs wrote:
> Hi,
>
> Review comments for the jimage code in java.base, mostly cleanup but
> perhaps a bug or two.
> General: inconsistent style and not following guidelines, copyright
> dates may need an update.
> Use of assert for error checking is not going to catch or help isolate
> errors in production builds.
I think Jim Laskey is going to reply to you on these comments.
On copyright dates then I submitted an issue a few weeks ago to schedule
a bulk update in JDK 9. This hasn't been done for some time and there
are many files that need their dates updated.
-Alan
More information about the jigsaw-dev
mailing list