Initial webrev with changes for JDK 9

[Phil Race]

http://cr.openjdk.java.net/~alanb/8142968/2/jdk/test/java/awt/patchlib/java.desktop/java/awt/Helper.java.html

   30         //java.awt.Helper.class.getModule().addExports(pn, target);

Can we remove the commented out line ?

http://cr.openjdk.java.net/~alanb/8142968/2/jdk/src/java.desktop/macosx/classes/com/apple/laf/AquaUtils.java.sdiff.html

  368         // can we use ClassLoader.getSystemClassLoader here?
  369         final ClassLoader launcherClassLoader = ClassLoaders.appClassLoader();

I suspect yes, although it doesn't really matter and maybe this workaround method
is not needed any more but that is for another day.


http://cr.openjdk.java.net/~alanb/8142968/2/jdk/src/java.desktop/share/classes/java/awt/color/ICC_Profile.java.sdiff.html

This edit seems to be associated with the following change :-
changeset:   13355:df27ca47fd34
user:        alanb
date:        Sun Jul 12 21:24:44 2015 +0100
summary:     ICC_Profile.standardProfileExists doesn't close stream

This bug would affected mainline so why was this change not fixed there ?
I'm curious how it was found since there is no bug report mentioned.
Also I wonder if we really have to have to open a stream to test existence ?



http://cr.openjdk.java.net/~alanb/8142968/2/jdk/src/java.desktop/share/classes/javax/swing/text/DefaultFormatter.java.sdiff.html

< 34 import javax.swing.text.*;

http://cr.openjdk.java.net/~alanb/8142968/2/jdk/src/java.desktop/share/classes/javax/swing/text/html/ObjectView.java.sdiff.html
<   27 import java.util.Enumeration;

http://cr.openjdk.java.net/~alanb/8142968/2/jdk/src/java.desktop/share/classes/sun/applet/AppletSecurity.java.sdiff.html
<  46 import sun.security.provider.*;

Not sure why deleting a few unused imports needed to be part of this change.
It would have been less odd were it not the only change in these source
files.

http://cr.openjdk.java.net/~alanb/8142968/2/jdk/src/java.desktop/share/classes/sun/print/ServiceDialog.java.sdiff.html

Why were these changes made in jake ? I thought the policy was to make
all changes in mainline unless they could only be made in jake ?

Also I
1) don't see where/how the stream is closed
2) The doPrivileged at line 2823 no longer seems likely to be necessary.


Looking over the client related tests (or at least as many of them as I noticed) I am curious why this one :-

http://cr.openjdk.java.net/~alanb/8142968/2/jdk/test/java/awt/xembed/server/TesterClient.java.sdiff.html

uses

   35         cl.getModule().addExports("sun.awt.X11",TesterClient.class.getModule());

Instead ofjava.awt.Helper.addExports(..)




http://cr.openjdk.java.net/~alanb/8142968/2/jdk/test/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh.sdiff.html

Why was the "@" removed from this line :-

   31 #   compile TestWrapped.java

   31 #   compile TestWrapped.java

http://cr.openjdk.java.net/~alanb/8142968/2/jdk/test/java/awt/Mixing/AWT_Mixing
/OverlappingTestBase.java.sdiff.html

Why were lines 111&112 commented out but not lines 114 ?

-phil.

On 03/11/2016 01:39 AM, Alan Bateman wrote:
>
> I've refreshed the webrevs here:
>    http://cr.openjdk.java.net/~alanb/8142968/2
>
> so that we have a snapshot of what is currently in the jigsaw/jake 
> forest. The webrevs are against jdk-9+109.
>
> As I said in the last mail, we would like to integrate this snapshot 
> into JDK 9 before the end of March. The proposal is to aim to 
> integrate during the week of March 21, with the the week of March 28 
> as fallback in event of problems.
>
> The related JEPs (JEP 200, JEP 260, JEP 261 and JEP 282) are now in 
> "Proposed to Target" state. Mark send mail to jdk9-dev with this list 
> and other proposals yesterday.
>
> -Alan