RFR 8136645: jlink tool should create windows os compatible launcher

[Dmitry Samersoff]

Sundararajan,

Occasionally put my nose in. Just $0.2 ...

1. Do we really need separate .append("\n")? Also Windows convention is
"\r\n"

2. Is it possible to name a module using other languages (e.g. Russian
or Japanese). Is StandardCharsets.ISO_8859_1 appropriate in this case?

3. Is PosixFileAttributeView.class appropriate here? If yes - please add
a comment, because name is misleading.

-Dmitry

On 2016-03-31 20:38, Sundararajan Athijegannathan wrote:
> Please review http://cr.openjdk.java.net/~sundar/8136645/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8136645
> 
> Thanks,
> -Sundar
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.