RFR: JDK-8155237 - jlink plugin to order resources should take a class list as input
Mandy Chung
mandy.chung at oracle.com
Wed May 11 17:21:57 UTC 2016
> On May 11, 2016, at 10:17 AM, Jim Laskey (Oracle) <james.laskey at oracle.com> wrote:
>
>
>> On May 11, 2016, at 2:03 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>
>>
>>> On May 9, 2016, at 10:41 AM, Jim Laskey (Oracle) <james.laskey at oracle.com> wrote:
>>>
>>> Modifies the jlink sort-plugin to accept a classlist to order files in the jimage.
>>>
>>> http://cr.openjdk.java.net/~jlaskey/8155237/webrev/index.html
>>> https://bugs.openjdk.java.net/browse/JDK-8155237
>>
>> This looks good and also cleaned up the original code. I saw that it’s pushed which is fine.
>>
>> A small comment: this plugin should throw error if @file not exists.
>
> This is deliberate, since the classlist may not be there during one phase of the build. We could issue a warning.
>
At build time, it should know the image is created using classlist or not and so the —-order-resources option can only be specified when it’s present. This would help catching issue at link time in case if anything goes wrong.
>
>> Does jimage list command show the jimage entries in alphabetically order? It would be useful to provide an option to list the entries as layout in the jimage file (a RFE).
>
> Yes to alphabetically. Please post an RFE for file order.
>
OK.
Mandy
More information about the jigsaw-dev
mailing list