RFR 8158131: Nashorn should not use jdk.internal.module.Modules API

Alan Bateman Alan.Bateman at oracle.com
Mon May 30 17:55:24 UTC 2016


On 30/05/2016 11:43, Sundararajan Athijegannathan wrote:
> Updated nashorn webrev:
> http://cr.openjdk.java.net/~sundar/8158131/nashorn/webrev.01/
>
> * Added @link in ModuleGraphManipulator.java's javadoc
>
> * Using Context.class.getModule() in all places where nashorn module is
> needed
>
> * Using  all caps names for static final variables  - nashornModule,
> javaBaseModule, myModule  in generated
>
>
I looked over the changes and good to see it using the API to create 
dynamic modules. I assume folks familiar with the Nashorn code will do 
the detailed review.

-Alan


More information about the jigsaw-dev mailing list