RFR of JDK-8158149: test bug for SystemModuleFinder when fast path is supported
Hamlin Li
huaming.li at oracle.com
Tue May 31 03:38:56 UTC 2016
On 2016/5/31 9:11, Mandy Chung wrote:
>>> On 30/05/2016 12:48, Hamlin Li wrote:
>>>> Would you mind to review the following patch?
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8158149
>>>>
>>>> webrev: http://cr.openjdk.java.net/~mli/8158149/webrev.00/
>>>>
>>>>
>>>> The system property to disable fast path should be "jdk.system.module.finder.disabledFastPath" rather than "jdk.installed.modules.disable”.
> The fix looks fine. I missed this test when the system property was renamed.
Thank you Mandy.
> We also renamed “InstalledModuleDescriptorPlugin" to “SystemModuleDescriptorPlugin” before we integrated jigsaw to jdk9. Do you have cycle to rename the directory “InstalledModuleDescriptors” and any reference to “installed” to “system” in the tests in a separate patch (a separate JBS issue)?
Will file new bug to track the issue and send out for review.
Thank you
-Hamlin
> thanks
> Mandy
More information about the jigsaw-dev
mailing list