RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

Mandy Chung mandy.chung at oracle.com
Tue Nov 1 03:34:35 UTC 2016


> On Oct 31, 2016, at 8:26 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
> 
>> On Oct 27, 2016, at 5:22 PM, Steve Drach <steve.drach at oracle.com> wrote:
>> 
>> I’ve put out another webrev, http://cr.openjdk.java.net/~sdrach/8156499/webrev.05/, that addresses Mandy’s concerns.  In particular I demonstrate that the resultant image is “runnable” and that a Main class in the image can/cannot find the java.logging module when the module-info.class is changed to require java.logging in one case but not in the other.
> 
> Looks okay in general.  The jlink change looks correct.  Thanks for updating the test.

In fact - does this test run on windows?

 239         Path java = Paths.get(image, "bin", "java”);

On windows, shouldn’t this need to be “java.exe”?

Mandy


More information about the jigsaw-dev mailing list