[9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options
Jim Laskey (Oracle)
james.laskey at oracle.com
Thu Nov 3 13:34:58 UTC 2016
Nice work. +1
> On Nov 3, 2016, at 10:29 AM, Denis Kononenko <denis.kononenko at oracle.com> wrote:
>
> Hi,
>
> I've done some rework accordingly to Alan's and Shura's comments:
>
> 1) removed overlapped tests from JImageToolTest.java;
>
> 2) added new tests JImageVerifyTest.java for jimage verify;
>
> 3) reorganized jtreg's tags;
>
> The new WEBREV can be found here: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.01/
>
> Thank you,
> Denis.
>
> On 06.10.2016 19:37, Denis Kononenko wrote:
>> Hi,
>>
>> Could someone please review these new tests for jimage utility.
>>
>> There're 5 new files containing tests to cover use cases for 'info', 'list', 'extract' and other options. No new tests for 'verify'.
>>
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
>> WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.00/
>>
>>
>> Thank you,
>> Denis.
>
More information about the jigsaw-dev
mailing list