RFR 8166286: jmod fails on symlink to directory
Alan Bateman
Alan.Bateman at oracle.com
Fri Nov 4 15:48:40 UTC 2016
On 04/11/2016 11:34, Sundararajan Athijegannathan wrote:
> Hi,
>
> Thanks for the review. Please find the updated webrev:
> http://cr.openjdk.java.net/~sundar/8166286/webrev.01/
>
> * Reduced line length in JmodTask.java
> * Removed @bug comment - earlier I attempted a separate test file for
> this - comment carried over from that step.
> Using ordinary comment now
> * On module names: This jmod test file uses names like "foo" (unlike
> jlink tests). Hope the module name is fine.
>
This looks okay although I think it would be better to have a @bug in
the test description with 8142968, then add to it as needed when there
are bug fixes.
-Alan
More information about the jigsaw-dev
mailing list