RFR 8160359: Improve jlink logging for cases when a plugin throws exception
Claes Redestad
claes.redestad at oracle.com
Wed Nov 30 13:23:15 UTC 2016
Looks good to me!
/Claes
On 2016-11-30 12:05, Sundararajan Athijegannathan wrote:
> Please review fix for https://bugs.openjdk.java.net/browse/JDK-8160359
>
> jdk webrev: http://cr.openjdk.java.net/~sundar/8160359/webrev.01/
>
> top webrev: http://cr.openjdk.java.net/~sundar/8160359/top/webrev.01/
>
> This is mainly a debugging aid for jlink invocation - in particular from
> jdk makefiles. We'd like to get maximum info. like stack trace on
> exception from builtin plugin invocation from jdk makefiles.
>
> Main changes from earlier round:
>
> * Plugin.configure should throw only IllegalArgumentException (never
> PluginException) - as suggested by Mandy earlier.
>
> * jlink.debug turned on for JDK makefile's invocation of jlink (top
> webrev) - as suggested by Claes earlier.
>
> Earlier round of review:
>
> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-November/010034.html
>
> Thanks,
>
> -Sundar
>
More information about the jigsaw-dev
mailing list