[9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Denis Kononenko denis.kononenko at oracle.com
Thu Oct 6 23:05:07 UTC 2016


> >
> > Could someone please review these new tests for jimage utility.
> >
> > There're 5 new files containing tests to cover use cases for 'info',
> 
> > 'list', 'extract' and other options. No new tests for 'verify'.
> >
> > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240
> > WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.00/
> Do these tests overlap with the existing tests? Just wondering if 
> JImageToolTest should be removed as part of this.


Yes, they do. Overlapping occurs in very common use cases. 
However I wouldn't remove JImageToolTest, we need such a test to ensure:
1) bin/jimage exists;
2) bin/jimage properly communicates to jdk.tools.jimage.JImageTask;

I think it could be simplified to an invocation of jimage --version. 

Denis.


> 
> -Alan


More information about the jigsaw-dev mailing list