Review Request: JDK-8162401 Support multiple --add-exports and --add-reads with the same module/package
Mandy Chung
mandy.chung at oracle.com
Fri Oct 7 15:09:15 UTC 2016
> On Oct 7, 2016, at 12:03 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>
>
>
> On 06/10/2016 23:17, Mandy Chung wrote:
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8162401/webrev.00/
>>
>> Currently, `--add-exports` and `--add-reads` options do not accept duplicated module/package and it is an error to attempt to export the same package more than once on the command-line. There are cases where allow augmenting the command-line options to add `--add-exports` or `--add-reads`. jtreg is one example that currently parses the command-line options and has to merge properly if there exists a `--add-exports` option of a given module/package.
>>
>> This patch relaxes this restriction and allow multiple `--add-exports` and `--add-reads` options with the same module/package. In addition, these 2 options allow unknown module/package and emit a warning rather than as a fatal error, to be consistent with javac.
>>
> "Must be specified" might be clearer than "must not be empty". Otherwise looks good. Do you mind pushing this to jigsaw/jake at the same time as jdk9/dev? This is because there there are a few things that need adjustment for --add-exports-private, mostly tests that aren't in jake yet.
Yes I’ll adjust the fix and push to jake as well.
Mandy
More information about the jigsaw-dev
mailing list