RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

Steve Drach steve.drach at oracle.com
Wed Oct 19 22:35:29 UTC 2016


> On Oct 19, 2016, at 1:59 PM, Steve Drach <steve.drach at oracle.com> wrote:
> 
>>>> In JarArchive::entries then you filter out META-INF/MANIFEST.MF and I'm not sure that that is right (think modular JAR on the module path with a manifest, it's just a resource file).
>>> I took that out and it still works as expected.
>>> 
>>>> Are directories the only case where toEntry can return null, in which case would it simpler to filter out directories here.
>>> I’ve done that too.
>>> 
>>>> There is quite a bit of clean-up needed in this area (pre-dates your patch of course). Not clear why Archive isn't a Closeable for example, or why covariant returns aren't used by the more specialized JarArchive/JarEntry/etc. I'm sure you don't want to get into that but maybe we could at least make the JarFile available via a protected method rather than a field.
>>> I’ve made JarFile available via a protected method
>> This sounds good. Do you have an updated patch? (the current patch is webrev.03 and I couldn't find a webrev.04).
>> 
>> -Alan.
> 
> http://cr.openjdk.java.net/~sdrach/8164805/webrev.00/ <http://cr.openjdk.java.net/~sdrach/8164805/webrev.00/>
Argh!  Sorry about that.  Here’s the correct link http://cr.openjdk.java.net/~sdrach/8156499/webrev.04/ <http://cr.openjdk.java.net/~sdrach/8156499/webrev.04/>




More information about the jigsaw-dev mailing list