<i18n dev> RFR: 8165804: Revisit the way of loading BreakIterator rules/dictionaries

Naoto Sato naoto.sato at oracle.com
Thu Oct 20 16:24:39 UTC 2016


Looks good to me.

Naoto

On 10/20/16 1:33 AM, Masayoshi Okutsu wrote:
> Hi,
>
> Please review the changes for JDK-8165804 which is a follow-up of
> JDK-8076757. Some notes on the changes.
>
> - Removed INCLUDES := $(TEXT_PKG_LD) from
> make/gendata/GendataBreakIterator.gmk in order to avoid compiling
> non-BreakIterator*.java for the build tool with boot JDK.
>
> - Added sun.util.resources.BreakIteratorResourceBundle which handles
> loading of rule data and dictionaries. BreadIteratorResources* are its
> subclasses in the java.base and jdk.localedata modules.
>
> - In BreakIteratorResources*, regular ResourceBundle loading of
> BreakIteratorInfo* is avoided because a BreakIteratorInfo can't have its
> parent chain. For example, BreakIteratorInfo_th doesn't have the value
> for key "CharacterData" and BreakIteratorResources_th.handleGetObject()
> must return null for "CharacterData" rather than loading rule data given
> by the parent BreakIteratorInfo.
>
> - Moved RuleBasedBreakIterator, DictionaryBasedBreakIterator, and
> BreakDictionary to sun.text. BreakIteratorProviderTest.java was changed
> to deal with this refactoring.
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8165804
>
> Webrev:
> http://cr.openjdk.java.net/~okutsu/9/8165804/webrev.01
>
> Thanks,
> Masayoshi
>


More information about the jigsaw-dev mailing list