RFR: 8159523. Fix tests depending on absence of -limitmods in VM arguments.

Alexandre (Shura) Iline alexandre.iline at oracle.com
Wed Oct 26 19:53:09 UTC 2016


> On Oct 26, 2016, at 12:00 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 26/10/2016 19:33, Alexandre (Shura) Iline wrote:
> 
>> :
>> Like this:
>> http://cr.openjdk.java.net/~shurailine/8159523/webrev.04/
>> 
> It's all subjective but I prefer:
> 
> .addExports("java.base/jdk.internal.misc=ALL-UNNAMED")
> .addExports("java.base/jdk.internal.reflect=ALL-UNNAMED")
> 
> to:
> 
> .addExports("java.base", "jdk.internal.misc")
> .addExports("java.base", "jdk.internal.reflect")
> 
> only because I can immediately see what the packages are being exported to all unnamed modules.

Would this be better then?

.addExports("java.base", “jdk.internal.misc”, ALL_UNNAMED)
.addExports("java.base", "jdk.internal.reflect”, ALL_UNNAMED)
?

This is what I had in the previous version.

Shura

> 
> -Alan
> 
> 
> 



More information about the jigsaw-dev mailing list