Request Review: JDK-6479237 (cl) Add support for classloader names

Alan Bateman Alan.Bateman at oracle.com
Thu Oct 27 10:01:07 UTC 2016


On 26/10/2016 00:10, Mandy Chung wrote:

> Webrev at:
>     http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/webrev.00/
>
> Specdiff:
>     http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6479237/specdiff/overview-summary.html
>
> This is a long-standing RFE for adding support for class
> loader names.
One thing to check is getHashedModuleNames where it assumes the boot 
Layer exists, I assume this has the potential to NPE if we have any 
cases where a stack trace is printed during early startup.

Having classOrLoaderModuleClassName change from a class to a string a 
bit unusual but the reasons are clear.

Minor formatting issue in BuiltinClassLoader ctor (would look better 
without the line break).

The rest looks good to me.

-Alan.


More information about the jigsaw-dev mailing list