Review Request: JDK-8168205: Should not default class path to CWD if -cp is not specified but -m is specified
Alan Bateman
Alan.Bateman at oracle.com
Thu Oct 27 20:40:47 UTC 2016
On 27/10/2016 18:02, Mandy Chung wrote:
>> On Oct 27, 2016, at 2:44 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>>
>> The updated comment in ClassLoaders might be a bit clearer if you drop "if defined”.
>>
> OK, dropped “if defined”.
>
>> A minor comment on the test is that it could use ProcessTools.executeTestJava to avoid needing JAVA_TOOL.
> ProcessTools::executeTestJava launches the process inherited with CLASSPATH environment variable set. I can use ProcessTools::createJavaProcessBuilder that calls JDKToolFinder::getJDKTool to find the launcher instead of having the test finding the launcher (no difference anyway). I’m okay either way and updated the webrev:
>
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8168205/webrev.01/
>
Ah, I forgot CLASSPATH was inherited here. In any case, the updated
webrev looks okay to me.
-Alan
More information about the jigsaw-dev
mailing list