RFR 8163952: jlink exclude VM plugin does not support static libraries

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Sep 6 15:08:24 UTC 2016


Yep, my mistake - Sorry! Thanks for the catch. Will file a bug.

PS. I suspect test ran -- but jlink missed removing those .a static
libraries!

Thanks

-Sundar

On 9/6/2016 8:25 PM, Jim Laskey (Oracle) wrote:
> I missed that as well.  Good catch.
>
>
>> On Sep 6, 2016, at 11:50 AM, Anthony Vanelverdinghe <anthony.vanelverdinghe at gmail.com> wrote:
>>
>> Hi Sundar
>>
>> I'm not familiar with the code, but the for-loop at lines 105-107 looks like a bug, since only the first element is considered:
>>
>> 105             for (String jvmlib : jvmlibs) {
>> 106                 return t.path().endsWith("/" + jvmlib);
>> 107             }
>>
>> Kind regards,
>> Anthony
>>
>>
>> On 6/09/2016 12:12, Sundararajan Athijegannathan wrote:
>>> Please review http://cr.openjdk.java.net/~sundar/8163952/webrev.01/ for
>>> https://bugs.openjdk.java.net/browse/JDK-8163952
>>>
>>> Thanks,
>>>
>>> -Sundar
>>>



More information about the jigsaw-dev mailing list