RFR 8165772: fix for 8165595 results in failure of jdk/test/tools/launcher/VersionCheck.java

Alan Bateman Alan.Bateman at oracle.com
Mon Sep 12 12:37:33 UTC 2016


On 12/09/2016 13:32, Sundararajan Athijegannathan wrote:

> Bug: https://bugs.openjdk.java.net/browse/JDK-8165772
>
> This VersionCheck.java test failed after main class was added to nashorn
> modules. VersionCheck expects all jdk/bin tools to be derived from the
> standard launcher. But, jlink generates shell scripts and batch files
> for modules with main class.  I'm reverting back nashorn module main
> class addition makefile change and also removing VersionCheck from
> ProblemList.txt:
>
> Webrevs:
>
> Top: http://cr.openjdk.java.net/~sundar/8165772/top/webrev.02/
>
> Jdk: http://cr.openjdk.java.net/~sundar/8165772/jdk/webrev.02/
>
> I'm withdrawing my earlier jlink fix attempt:
> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-September/009339.html
>
Looks okay (and I agree that dropping this is the right thing to do as 
jlink generating launcher scripts is just isn't aligned with modules 
that include pre-built launchers).

-Alan


More information about the jigsaw-dev mailing list