Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

[Andrew Dinn]

On 03/04/17 19:41, Mandy Chung wrote:
> Webrev:
>   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webrev.00/
> 
> This revisits the OS name and arch in packaging JDK modules
> to extend the module descriptor with ModuleTarget class file
> attribute.  We considered matching with the system properties.
> Linux x64 JDK can run on a system whose `os.arch` system
> property value can be `amd64` or `i586` or `x86_x64`.  
> Similiarly, windows x86/x64 JDK can run on a system whose 
> `os.name` system property starts with “Windows” as the 
> os.name property is set to "Windows XXX" for example 
> "Windows Server 2012 R2”.  It might be worth considering
> multiple OS arch values in ModuleTarget in the future.
> 
> JDK bundle names are revised in JDK 9.  This is a good
> alternative to be consistent with $OS-$ARCH value in 
> the bundle names.  This patch proposes to package JDK modules 
> with OS name and arch to match the values as in JDK bundle names.
> jlink will generate the `release` file and set OS_NAME and
> OS_ARCH to those values.  This also proposes to drop 
> OS_VERSION to align with the ModuleTarget class file attribute.
> 
> This shows the old and new value of OS_NAME/OS_ARCH properties
> in the `release` file:
> 
>             JDK 8               JDK 9
>             -----               -----
> OS_NAME     Linux               linux
>             SunOS               solaris
>             Darwin              osx
>             Windows             windows
>              
> OS_ARCH     i386,x86            x86
>             i586,amd64,x86_64   x64
>             sparcv9             sparcv9
>             arm                 arm32
>             aarch64             arm64

arm64 is *not* a correct name for the AArch64 architecture. There is in
fact no arm64 architecture. The latter name has been used to identify
the Oracle-developed port but that fact does not sanction its use for
OS_ARCH.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander