8177530: Module system implementation refresh (4/2017)

Mandy Chung mandy.chung at oracle.com
Wed Apr 5 22:43:10 UTC 2017

> On Apr 4, 2017, at 9:28 AM, Alan Bateman <alan.bateman at oracle.com> wrote:
> The webrev with the changes is here:
>  http://cr.openjdk.java.net/~alanb/8177530/1

I reviewed all changes.  Looks good in general with a few minor comments:

 221                         String prefix;
 222                         if (mref.descriptor().isAutomatic()) {
 223                             prefix = "Automatic module";
 224                         } else {
 225                             prefix = "Module";
 226                         }

It may be nice for this tracing output to follow similar format as to —-list-module output (e.g “automatic” following the name/location)

 216  * <p> Service loaders created to locate providers in a {@linkplain module layer}

 996                     .ifPresent(any -> ostream.print(" automatic"));

It might be useful to indicate if the required module is not observable.

   I think redefineModule should check isModifiableModule even the current implementation returns true for all modules.


More information about the jigsaw-dev mailing list