RFR 8178323: Add negative tests for bind services Jlink feature

Mandy Chung mandy.chung at oracle.com
Sat Apr 8 00:18:52 UTC 2017

> On Apr 7, 2017, at 8:40 AM, Andrey Nazarov <andrey.x.nazarov at oracle.com> wrote:
> Hi, 
> Please review 3 negative tests for Jlink which tests new bind-services/suggest-providers feature.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8178323
> webrev: http://cr.openjdk.java.net/~anazarov/8178323/webrev.00/webrev/ 

Thanks for adding these tests.


 155         Path dir = Paths.get("verboseNoop”);

I suggest to rename “verboseNoop” to “verboseNoBind”

line 159-161: formatting nit: can you add spaces to align with the first
argument in line 158.  Same comment to SuggestProviders.java line 180-182
an 198-200.

  It may be better to rename “suggestNotProvider" to “noSuggestedProvider".

  In the noOneUsesProvider test case, is m4 not observable? I think 
jlink should fail with m4 not found. When —-suggest-providers is 
specified with a service type, it’s a bug in the implementation that 
does not report it.  This should be renamed to “nonObservableModule”
instead.  We should file a bug and include this test case in the JBS report.


More information about the jigsaw-dev mailing list