Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

Mandy Chung mandy.chung at oracle.com
Sat Apr 8 14:52:28 UTC 2017


> On Apr 8, 2017, at 12:21 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 08/04/2017 06:50, Mandy Chung wrote:
> 
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8177844/webrev.01/
>> 
>> This fixes -—patch-module to do hash checking on the module being patched
>> so that it will ensure that a non-upgradeable module remains not upgradeable.
>> 
>> 
> The comment at L523 needs updating too, otherwise looks good.
> 

will take that out.

> Given that this can't be pushed to jdk9/dev until the issue deploying Graal is fixed then I think we should just push this fix to jake and move on. It will go into jdk9/dev with the next update (which I hope will be the last update).

I was thinking to push this to jdk-9+166 but pushing it to jake will probably be a better option for Doug.

Mandy



More information about the jigsaw-dev mailing list