RFR 8178323: Add negative tests for bind services Jlink feature
Mandy Chung
mandy.chung at oracle.com
Fri Apr 21 00:46:01 UTC 2017
> On Apr 20, 2017, at 5:12 PM, Andrey Nazarov <andrey.x.nazarov at oracle.com> wrote:
>
> HI Mandy,
>
> I’ve update patch http://cr.openjdk.java.net/~anazarov/8178323/webrev.03/webrev/ <http://cr.openjdk.java.net/~anazarov/8178323/webrev.03/webrev/>
Nit: use 4-space indent e.g. BindServices.java. line 159 (the following lines will move along) and SuggestProviders.java line 255-258, 262, 273-276, and 280.
Otherwise looks good.
You can fix the formatting before push.
Thanks
Mandy
More information about the jigsaw-dev
mailing list