Review Request: 8179025: Exclude deployment modules from FieldSetAccessibleTest.java and VerifyJimage.java

[Peter Levart]

Hi Mandy,

In order to make the FieldSetAccessibleTest more resilient to future 
changes (i.e. adding / renaming modules), perhaps the modules to be 
excluded in the check should be explicitly listed by their names? 
Currently your rule, when negated, lists the following modules:

javafx.deploy
jdk.deploy
jdk.javaws
jdk.plugin.dom
jdk.plugin
jdk.deploy.controlpanel
jdk.plugin.server

...which is not to much to put in a Set.of(....) instance.

There's no harm if future changes forget to add/change this set, but it 
would be wrong if the rule you have now, inadvertently excludes some 
future module that should be checked.

Regards, Peter


On 04/21/2017 10:53 PM, Mandy Chung wrote:
> Webrev:
>     http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8179025/webrev.00/index.html
>
> These tests failed due to IAE when loading types from the deployment
> modules which are expected to be defined when running with javaws
> or plugin.  This revises the tests to exclude these modules to
> remove the tests from the problem list.  In the long term, we
> should look into some way not to link in these modules in the image.
>
> This patch also updates JdkQualifiedExportTest.java test to take out
> the exception for deployment modules to have qualified exports to
> upgradeable modules.
>
> thanks
> Mandy