Review Request: 8179025: Exclude deployment modules from FieldSetAccessibleTest.java and VerifyJimage.java

[Mandy Chung]

> On Apr 23, 2017, at 4:09 AM, Alan Bateman <alan.bateman at oracle.com> wrote:
> 
> On 22/04/2017 16:42, Mandy Chung wrote:
> 
>> Have an explicit list is another alternative.  OTOH I think only deployment modules will name with these words though which was what I initially want to cover.
>> 
>> Since only 4 modules we are concerned about,  I updated the patch to list the ones needed to be excluded rather than a superset as you suggest:
>> 
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8179025/webrev.01/
>> 
>> 
> The updated filter looks okay to me.
> 
> In JdkQualifiedExportTest.accept then "cf.findModule(target).orElse(null) == null" looks a bit odd (I assume this is what promoted Peter bringing up isEmpty on core-libs-dev.  There are a dozen ways you could do this of course, only alternative is:
>    return cf.findModule(target).map(m -> false).orElse(true);

Indeed looks a little odd.  I prefer using isPresent since this method intends to return true if the target is not in the resolved graph.

   return !cf.findModule(target).isPresent();

Mandy