Review Request: JDK-8186145: tools/launcher/modules/validate/ValidateModulesTest.java fails when launched with -XX:+EnableJVMCI

[Alan Bateman]

On 24/08/2017 19:05, mandy chung wrote:
> java --validate-modules requires only java.base to do the validation 
> and hence the current implementation creates a minimum boot layer with 
> java.base only.  It fails when running with -XX:+EnableJVMCI when VM 
> attempts to load JVMCI class which is not in the boot layer.  This 
> patch changes the minimal boot layer to resolve all system modules 
> that should get --validate-modules to work with some VM options that 
> add some module at runtime.
>
> Webrev:
> http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8186145/webrev.00/
Looks okay except L218 where the comment needs to be updated to say that 
it starts without an application module path.

I also wonder if a test is possible, it could use "@requires vm.jvmci" 
so that it only runs when that capability is present.

-Alan