RFR 8185130: jlink should throw error if target image and current JDK versions don't match

Claes Redestad claes.redestad at oracle.com
Tue Dec 5 13:32:11 UTC 2017


Hi,

just a note that the check you're removing in GenerateJLIClassesPlugin 
was stricter
(also required same minor version), but the choice to do that was more 
or less an
arbitrary one. Checking only major is likely going to be sufficient.

Apart from that I think this is a welcome change, as making the more 
complex jlink
plugins work across multiple JDK versions are going to be very 
error-prone and
complicated (this might change as tools and APIs evolve...)

Thanks!

/Claes

On 2017-12-05 14:34, Sundararajan Athijegannathan wrote:
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8185130
> Webrev: http://cr.openjdk.java.net/~sundar/8185130/webrev.00/index.html
>
> Thanks,
> -Sundar



More information about the jigsaw-dev mailing list