Review Request JDK-8160286: jmod hash is creating unlinkable modules.
Paul Sandoz
paul.sandoz at oracle.com
Thu Jan 12 16:54:10 UTC 2017
> On 11 Jan 2017, at 19:02, Mandy Chung <mandy.chung at oracle.com> wrote:
>>
>> Make static?
>>
>
> It could but the Hasher class needs to be made static too and pass in other instance variables from JmodTask. There are other inner classes in JmodTask that accesses JmodTask instance variables. I prefer to leave this for a future clean up to make the implementation consistent, if this is okay with you?
>
Yes, i missed the overall context when looking at the patch.
Paul.
More information about the jigsaw-dev
mailing list