Review Request: JDK-8173096 jmod files are not world-readable

[Peter Levart]

Hi Mandy,

On 01/21/2017 03:32 AM, Mandy Chung wrote:
> Updated webrev to put the temporary file in the same containing directory of the target file:
>    http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01

That's ok. Maybe also specify ATOMIC_MOVE to CopyOption ... options in 
Files.move() ? Currently the move will be atomic (rename in UNIX 
terminology) because the source and target are in the same directory, 
but if renaming fails for some reason, it will try the fallback to 
copy(src, dst) + remove(src). If you add ATOMIC_MOVE to options, failure 
to rename will result in exception. I don't know which one do you prefer?

Regards, Peter

> I want to fix this regression in jdk-9+154.  We can revisit the approach after this fix if necessary.
>
> Mandy
>
>> On Jan 20, 2017, at 8:55 AM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>
>> Webrev:
>>    http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.00/index.html
>>
>> A recent change in jmod tool [1] creates the JMOD file with no group
>> and other readable permission as that’s the default permission when
>> creating a temporary file with Files::createTempFile.  This fixes
>> the permission issue by creating the JMOD file in a temporary directory.
>>
>> Mandy
>> [1] https://bugs.openjdk.java.net/browse/JDK-8173096