Review Request: JDK-8173096 jmod files are not world-readable

Chris Hegarty chris.hegarty at oracle.com
Mon Jan 23 15:12:04 UTC 2017


On 21/01/17 02:32, Mandy Chung wrote:
> Updated webrev to put the temporary file in the same containing directory of the target file:
>   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01

Looks fine. Trivially, the test can now drop "-Djava.io.tmpdir=." .

-Chris.

> I want to fix this regression in jdk-9+154.  We can revisit the approach after this fix if necessary.
>
> Mandy
>
>> On Jan 20, 2017, at 8:55 AM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>
>> Webrev:
>>   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.00/index.html
>>
>> A recent change in jmod tool [1] creates the JMOD file with no group
>> and other readable permission as that’s the default permission when
>> creating a temporary file with Files::createTempFile.  This fixes
>> the permission issue by creating the JMOD file in a temporary directory.
>>
>> Mandy
>> [1] https://bugs.openjdk.java.net/browse/JDK-8173096
>


More information about the jigsaw-dev mailing list