Request Review: JDK-8181639 Add tool and services information to module summary

Mandy Chung mandy.chung at oracle.com
Wed Jun 7 17:58:45 UTC 2017


I updated the javadoc per your comment/suggestion.  My reply to some
of your comments are inlined below.

Webrev:
  http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181639/webrev.01/

Module summary pages:
  http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8181639/api/


> On Jun 7, 2017, at 3:36 AM, Alan Bateman <alan.bateman at oracle.com> wrote:
> java.desktop
> - I'm in two minds so to whether the @provides should be documented in this module. This is a case where the docs should make it clear that the java.desktop includes built-in implementations and list the image and sound formats that are supported.
> 

That’s a fair point.  I took out @provides and will file a JBS issue
for the client team to document the builtin providers as appropriate.

> jdk.zipfs
> I also think we need a table in this javadoc to document the "create" and "encoding" properties.
> 

I agree.  I will file a JBS issue for this.

> jdk.security.auth
> - your update looks fine but we should probably submit a bug to get package descriptions added or maybe more text as it's not immediately obvious what one can do with this module.
> 

and jdk.xml.dom as well.  Will file issues to track this.

> jdk.scripting.nashorn
> - the existing module-info.java is inconsistent with the other module descriptions. Now might be the opportunity to reformat this.

I was tempted to reformat it and now I have done it in webrev.01.

Mandy




More information about the jigsaw-dev mailing list