8181087: Module system implementation refresh (6/2017 update)
Alan Bateman
Alan.Bateman at oracle.com
Fri Jun 16 12:47:47 UTC 2017
On 14/06/2017 22:44, Peter Levart wrote:
> :
>
>
> In j.l.Module:
>
> There are two places in the same method that contain exactly the same
> fragment of code:
>
> 566 if (targets.contains(EVERYONE_MODULE) ||
> targets.contains(other))
> 567 return true;
> 568 if (other != EVERYONE_MODULE
> 569 && !other.isNamed() &&
> targets.contains(ALL_UNNAMED_MODULE))
> 570 return true;
>
> Perhaps this could be factored out into separate private method which
> could also be made a little more optimal (when other ==
> EVERYONE_MODULE and targets does not contain it, it is looked-up twice
> currently).
Okay, make sense, I'll do that.
-Alan
More information about the jigsaw-dev
mailing list